Skip to content

Rename setServerParameters() to haveServerParameters(); drop haveServerParameter() #26

Description

@ThomasLandauer

Just stumbled upon this while searching for a new name for deleteHeader(), see #22

Current situation:

I would say:

  • "setServerParameters" isn't the right term, Codeception's convention for this is "haveServerParameters".
  • It doesn't make sense to have two functions for this, one for a single parameter, and one for multiple. If the expected argument is an array, anybody knows immediately what to pass. So the existing haveServerParameter can be deprecated in favor of the new haveServerParameters.
  • Remaining question: Is the "Symfony BrowserKit" thing more of a bug or more of a feature?
    If feature: Just pass the array along to Symfony's setServerParameters, and that's it.
    If bug: foreach() over the array and use Symfony's setServerParameter.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions