add wire format parser and serializer for booleans , strings and arrays - #575
Open
Devansh-18155 wants to merge 1 commit into
Open
add wire format parser and serializer for booleans , strings and arrays#575Devansh-18155 wants to merge 1 commit into
Devansh-18155 wants to merge 1 commit into
Conversation
Author
|
@pradeeban Could you please review my PR when you get a chance. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the MATLAB only supported flat numeric arrays because
concore_read.mwas using regex to strip all brackets and parsing only floats withsscanf. This caused booleans and strings to be silently dropped and flattened nested lists . alsoconcore_write.mwas usingnum2strwhich broke when trying to send cell arrays or strings.Added a parser (
concore_literal_eval.m) and serializer (concore_literal_serialize.m) that properly handle booleans, strings with escapes, nested lists, tuples, and numbers in MATLAB native types (cell arrays, logicals).Fixes #574