Skip to content

Don't run pyright basic checks on projects with strict pyright settings in CI #16005

Description

@hamdanal

Relevant CI configuration:

- name: Run pyright with basic settings on all the stubs
uses: jakebailey/pyright-action@v3
with:
version: PATH
python-platform: ${{ matrix.python-platform }}
python-version: ${{ matrix.python-version }}
annotate: ${{ matrix.python-version == '3.13' && matrix.python-platform == 'Linux' }} # Having each job create the same comment is too noisy.
- name: Run pyright with stricter settings on some of the stubs
uses: jakebailey/pyright-action@v3
with:
version: PATH
python-platform: ${{ matrix.python-platform }}
python-version: ${{ matrix.python-version }}
annotate: ${{ matrix.python-version == '3.13' && matrix.python-platform == 'Linux' }} # Having each job create the same comment is too noisy.
project: ./pyrightconfig.stricter.json

This could lead to a deadlock situation with Schrodinger's pyright: ignore comments that are only relevant to the strict run but throw error: Unnecessary "# pyright: ignore" in the basic checks run. See recent CI runs in #16004 for an example.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    project: infrastructuretypeshed build, test, documentation, or distribution related

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions