Skip to content

fix(roottest) :- resolve cms-00 datamodelevolution WILLFAIL in io/cms-00 - #23506

Open
Aaravanand00 wants to merge 1 commit into
root-project:masterfrom
Aaravanand00:fix/roottest-io-cms00
Open

Aaravanand00 wants to merge 1 commit into
root-project:masterfrom
Aaravanand00:fix/roottest-io-cms00

Conversation

@Aaravanand00

Copy link
Copy Markdown

Description

Re-enables CMS experiment data model backward compatibility regression tests (test2, reflex_test2, test3, reflex_test3) in roottest/root/io/datamodelevolution/cms-00. Removes WILLFAIL flags across CInt and Reflex dictionary fixtures.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 16h 50m 22s ⏱️
 3 869 tests  3 867 ✅ 0 💤 2 ❌
79 949 runs  79 947 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 321a830.

♻️ This comment has been updated with latest results.

@guitargeek

Copy link
Copy Markdown
Contributor

Thanks for the PR, but now it makes no net change: the second commit is a revert of the first. Was that intentional?

@Aaravanand00

Aaravanand00 commented Sep 27, 2026 •

Copy link
Copy Markdown
Author

Thanks for the PR, but now it makes no net change: the second commit is a revert of the first. Was that intentional?

yes I'll check this why checks was failed and other stuffs also after checks all the things I'll push the changes

@Aaravanand00

Copy link
Copy Markdown
Author

Hi @guitargeek ,
Apologies for the previous commit history. I have cleaned up the pr into a single commit with a minimal 2-line C++ fix.

Root Cause
In roottest/root/io/datamodelevolution/cms-00/test2.cxx, the dictionary path was hardcoded with a relative ./ prefix ("./libDataModelV2_dictcint"). When executing CTest from build directories, this relative ./ path caused gSystem->Load() to fail to locate the compiled dictionary shared library.

Resolution

  1. test2.cxx :- Removed the ./ prefix from dictname ("libDataModelV2_dictcint" and "libDataModelV2_dictrflx"), allowing gSystem->Load() to dynamically resolve the dictionary path.
  2. CMakeLists.txt :- Re-enabled the tests by removing WILLFAIL flags from test2, reflex_test2, test3, and reflex_test3.

@Aaravanand00

Copy link
Copy Markdown
Author

@guitargeek ptal why checks failed I didn't understand...

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants