Skip to content

fix(roottest): resolve templateName and strings WILLFAIL in treeformula/parse - #23508

Closed
Aaravanand00 wants to merge 1 commit into
root-project:masterfrom
Aaravanand00:fix/roottest-treeformula-parse
Closed

Aaravanand00 wants to merge 1 commit into
root-project:masterfrom
Aaravanand00:fix/roottest-treeformula-parse

Conversation

@Aaravanand00

Copy link
Copy Markdown

Description

Re-enables TTreeFormula string parsing (strings) and template proxy name generation (templateName) in roottest/root/treeformula/parse after validating grep conversion filters (OUTCNVCMD). Removes WILLFAIL flags.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 8h 55m 41s ⏱️
 3 847 tests  3 844 ✅ 0 💤  3 ❌
72 919 runs  72 895 ✅ 0 💤 24 ❌

For more details on these failures, see this check.

Results for commit 5ce02b3.

♻️ This comment has been updated with latest results.

@Aaravanand00
Aaravanand00 force-pushed the fix/roottest-treeformula-parse branch from c6d00e0 to 5ce02b3 Compare September 27, 2026 20:07
@Aaravanand00

Copy link
Copy Markdown
Author

Hi @guitargeek

Here is the actual fix for the strings test in roottest/root/treeformula/parse :-

Root Cause

  1. Undeclared Identifier in runstrings.C :-
    The declaration and retrieval of t_its was conditionally wrapped inside #ifdef ClingWorkAroundMissingDynamicScope. In modern Cling macro execution, this macro is not defined during interpreted execution, causing t_its to be undeclared (error: use of undeclared identifier 't_its').

  2. Reference Output Discrepancy in strings.ref :-
    The reference file had a leading newline and a typo on line 2 (Processing runstring.C... missing the trailing s), whereas ROOT outputs Processing runstrings.C....

  3. Scope Clarification :-
    templateName retains its documented WILLFAIL tag (due to platform-dependent compiler output differences noted in the CMake file), ensuring this PR only enables and resolves the strings test.

Solution

  • Unconditionally declared and retrieved TTree *t_its via _file0->GetObject("t_its", t_its); in runstrings.C.
  • Fixed the macro name typo and removed the superfluous leading newline in strings.ref.
  • Removed WILLFAIL and the obsolete comment for strings in CMakeLists.txt.

@Aaravanand00

Copy link
Copy Markdown
Author

@guitargeek ptal why these checks failed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant