Conversation
lgritz
reviewed
Jul 6, 2026
lgritz
left a comment
lgritz
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good!
Needs clang-format fix, just in one isolated spot
Allocate FFmpeg swscale destination buffers with a safe image alignment and validate the size, fill, and scale operations before using decoded pixels. This prevents narrow planar 16-bit conversions from writing past OIIO's destination buffer. Signed-off-by: Dongju Lee <dongpago2@gmail.com>
br0nzu
force-pushed
the
public-ffmpeg-swscale-output-buffers
branch
from
July 7, 2026 00:09
c00dce7 to
91038b2
Compare
Contributor
Author
|
Thanks, fixed. |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Jul 15, 2026
…5301) This aligns FFmpeg/libswscale destination image buffers and validates the buffer-size, frame-fill, and swscale return paths before decoded pixels are consumed. The change prevents narrow high-bit-depth VP9/GBR inputs from writing past OIIO's destination buffer during swscale conversion, and adds a regression case for the width-1 high-bit-depth FFmpeg path. Signed-off-by: Dongju Lee <dongpago2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns FFmpeg/libswscale destination image buffers and validates the buffer-size, frame-fill, and swscale return paths before decoded pixels are consumed.
The change prevents narrow high-bit-depth VP9/GBR inputs from writing past OIIO's destination buffer during swscale conversion, and adds a regression case for the width-1 high-bit-depth FFmpeg path.