Conversation
Osayi-ANL
left a comment
There was a problem hiding this comment.
attributes duplicates the two new fields. It's frame_attributes plus fallback_attributes merged.
The size check bills arrays twice (frame_delivery.py:80), and capture() can duplicate them in memory (:82, :48).
Suggestion: derive attributes instead of storing it. Nothing in src/ reads it.
No impact on a real detector run, but worth fixing before merge.
|
Good catch—fixed in d99f231. |
Goal
Keep frame-attached metadata separate from latest-value CA fallback so downstream analysis can tell what was measured with the frame. Also carry an explicit geometry revision when the stream supplies one.
Why
The combined metadata mapping remains for compatibility, but scientific consumers now have unambiguous provenance without copying or hashing full Q arrays.
Automated checks
ruff check src/dashpva/Human test plan
take_latest_frame(), confirmframe_attributesexcludes CA fallback values andfallback_attributescontains only those fallback values.No new CLI command or viewer control is added.
Refs #150.