Skip to content

feat: expand chord dictionary shapes, improve diagram rendering, and add instrument settings - #30

Merged
Apoll011 merged 3 commits into
masterfrom
develop
Sep 27, 2026
Merged

Apoll011 merged 3 commits into
masterfrom
develop

Conversation

@Apoll011

Copy link
Copy Markdown
Owner

Description

Summary

Expands the chord dictionary across fretted instruments (guitar, ukulele) and piano, improves diagram rendering with capo markers and centered finger indicators, resolves chord label collision in lyrics, and introduces per-instrument diagram and voicing preferences in the settings UI.

Changes

  • Expanded Chord Dictionary & Voicings:

    • Added curated open and slash chord shapes for guitar and ukulele.
    • Enhanced piano voicings with support for compact (rootless) 7ths and left-hand slash bass notes to avoid crowded diagrams.
    • Plumbed instrument-specific voicing styles through the chord dictionary pipeline.
  • Chord Diagram Rendering & Formatting:

    • Implemented visual capo clamp markers on fretted chord diagrams.
    • Centered finger numbers within chord diagram dots for improved clarity.
    • Added horizontal padding between adjacent chord/lyric cells to eliminate visual collisions.
  • Instrument Settings UI:

    • Added dedicated per-instrument diagram and voicing controls to the settings screen.
    • Persisted user instrument preferences and fed them directly into the chord rendering engine.
  • Maintenance:

    • Bumped version to 1.2.8.

Performance / UX

  • Significantly improved legibility of chord diagrams on mobile screens with centered finger markings and uncluttered slash chord representations.
  • Visual capo indicators on fretted charts for quick live reference during worship services.
  • Clean chord label separation across dense lyric lines.

Technical Details

  • Extended the chord dictionary architecture to accept instrument-specific preferences dynamically.
  • Refined chord grid cell layout logic to ensure proper horizontal separation between tightly packed chord annotations.

Notes

  • Version bumped to 1.2.8.

Apoll011 and others added 3 commits September 28, 2026 00:05
Add many more curated guitar/ukulele open and slash shapes, and let piano
honour compact (rootless) 7ths plus left-hand slash bass so A/C#-style
diagrams stop looking crowded. Preferences are plumbed through the
dictionary so each instrument can keep its own voicing style.

Co-authored-by: Cursor <cursoragent@cursor.com>
Draw a CifraClub-style capo clamp on fretted diagrams, centre finger
numbers in the dots, and pad tight lyric cells so adjacent chords no
longer glue together. Persist per-instrument diagram/voicing options on
the settings page and feed them into the renderer.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Apoll011
Apoll011 merged commit 4c38f19 into master Sep 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant