Repository navigation
feat(mailer): Return-Path for suspension notices from MAILER_SUSPENSION_BOUNCE_ADDRESS - #586
Merged
Merged
Conversation
…ON_BOUNCE_ADDRESS Bounces of SuspendAfter5Reminders notices need no support action: the members are suspended when the mailing is queued. With the variable set, those notices use it as Return-Path (SMTP envelope sender), so bounces go to a mailbox Znuny does not fetch and the bounce-processor reads instead. From stays reminder@, so human replies still reach Znuny. Unset = no change. (BeWelcome/sysadmins-infra#654, Gabriel's request)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target branch:
main(prod build source since rox#518). Part of BeWelcome/sysadmins-infra#693 (Gabriel's request).Why
Bounces of the suspension notices (
SuspendAfter5Reminders) need no support action, because the members are suspended when the mailing is queued (enqueueSuspensionNotification). Today they come back toreminder@and land in Znuny's Newsletter queue as tickets.Change
Mailer::sendNewsletterEmail: forSuspendAfter5Remindersonly, set the email's Return-Path fromMAILER_SUSPENSION_BOUNCE_ADDRESS. Symfony Mailer uses it as the SMTP envelope sender, so bounces go tobounces-suspended@bewelcome.org, which Znuny does not fetch and the bounce-processor reads (sysadmins-infra#683).reminder@bewelcome.org, so a member who replies still reaches the support team in Znuny.config/services.yaml: bind$suspensionBounceAddresswith%env(default::MAILER_SUSPENSION_BOUNCE_ADDRESS)%. Unset or empty means no change.Infra half: BeWelcome/sysadmins-infra#684 (prod
bounces-suspended@bewelcome.org, stagebounces-suspended@stage.bewelcome.org). Safe in either order.Tests
php -lclean.sha-5902327, before the rebase ontomain) built with all jobs green, including the image scan. This PR's CI builds a fresh image.Return-Path: <bounces-suspended@stage.bewelcome.org>in Mailpit while From is stillreminder@.