Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-36817651965.zip |
github-actions
Bot
added
the
Download in Comments
3 of 4 tasks
Contributor
|
Fixed in logic, XML changes are no longer required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions
none
Changes
Because of
VWE_Gun_HandCannonandVWE_Gun_HandCannon_Uniquehad different ammosets and one is the parentdef of another ammo inject is not injectingAmmoSet_460SWMagnumReferences
bugs chat https://discord.com/channels/278818534069501953/324222101550661663/1555058985902542920
Reasoning
XML first, idk how the bug works in logic
Alternatives
C# fix the underline ammo inject bug
Testing
Check tests you have performed: