Repository navigation
corrected bug in demofile.cpp - #733
Merged
Merged
Conversation
the function DemoWriteAttachObjRad was writing the wrong opcode (0x13 instead of 0x14), which may cause problems for demo playbacks (the respective blocks following the opcode have different size)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
the function DemoWriteAttachObjRad was writing the wrong opcode (0x0D instead of 0x0E), which may cause problems for demo playbacks (the respective blocks following the opcode have different size).
Checklist
[ X ] I have tested my changes locally and verified that they work as intended.
(no issue on newly built version of the game, and upon checking hex of .dem files, 0x0E happen where they should instead of 0x0D)
[ X ] I have documented any new or modified functionality.
no actual doc, but's the change is one line, and problem was explained.
[ X ] I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
[ X ] I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.