Fix incorrect references to non-existent AdvancedOptions class - #86
Merged
Merged
Conversation
These references in the README should refer to `AdvancedSettings` instead. The subsequent calls in the README to `HttpClients.NewHttpClient` already were passing in a `advancedSettings` variable, so this lets these examples work.
Justin Hammond (Justintime50)
approved these changes
Mar 9, 2026
Justin Hammond (Justintime50)
left a comment
Justin Hammond (Justintime50)
left a comment
Member
There was a problem hiding this comment.
Thanks for the correction! 😃
Justin Hammond (Justintime50)
merged commit Mar 9, 2026
fb03351
into
EasyPost:master
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These references in the README should refer to
AdvancedSettingsinstead. The subsequent calls in the README toHttpClients.NewHttpClientalready were passing in aadvancedSettingsvariable, so this lets these examples work.Testing
N/A
Pull Request Type
Please select the option(s) that are relevant to this PR.