Conversation
philmoz
force-pushed
the
philmoz/refactor-window-delete
branch
from
September 18, 2026 04:40
eab7ae3 to
b574f5d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently window closure and deletion logic on color radios is handled through:
Apart from the issues that can occur if 'deleteLater' does not call its parent, the order of Window closure is dependent on how each 'deleteLater' function is coded and is somewhat non-deterministic. The 'deleteLater' and closeHandler code may also check if the window has already been closed to prevent recursive loops.
This PR replaces this with the following:
For any window closure logic, this removes the need to call parent class virtual functions, removes the need to check if a window has already been deleted, and makes the order of closure deterministic.