fix(nv14): About page button overlap, AFHDS2A bind prompt, AFHDS2A on external bay

[pfeerick]

Three NV14 fixes (but first will effect EL18 / all portrait layouts).

1. About page: "Modules / RX version" button overlaps the version text

The button sat at a fixed position at the bottom of the info box. On NV14 (portrait, PL18 family), hardware shows extra LCD: / Touch: lines, which the simulator doesn't. On 2.12 that is enough to push the last line of text under the button. Main has a slightly taller page, so it currently fits there, but any extra line would cause the same overlap.

The version text now has its own scrolling area above the button:

• the button stays fixed at the bottom, in the same position as before;
• only the text scrolls, and only when it doesn't fit;
• the page opens showing the start of the text, and focusing the button doesn't scroll it.

When the text fits, the page looks the same as before.

Another commit makes the simulator show the LCD: / Touch: lines too, with "Simulator" as a placeholder value. Leaving those lines out is why the overlap never showed up in the simulator; now its About page matches the radio's. Verified on GX15 that this doesn't negatively impact horizontal screen radios.

2. AFHDS2A: Bind opens the FrSky "telemetry ON/OFF" menu and then doesn't bind

IS_D16_MULTI() / IS_R9_MULTI() only compared multi.rfProtocol and never checked the module type. For AFHDS2A that byte is flysky.rx_id[0], the low byte of the bound receiver ID.

If a receiver's ID ends in 0x0E, 0x3F or 0x40 (Multi FrSky X / X2 / R9), every later Bind press on the internal AFHDS2A module opens BindChoiceMenu. That menu then:

• writes the PXX receiver bits into rx_id[0];
• sets bind mode without restarting the AFHDS2A state machine, which drops straight back to normal mode. So there's no bind and no bind beeps.

This matches the report "altering channel range seems to prevent binding ... brings up telemetry on/off prompt then no bind beeps". The channel range change is most likely just when the rebind happened: the first bind stored an unlucky ID.

Both macros now check isModuleMultimodule(). That also covers the B&W model setup screens, which use isModuleD16() for the same menu. Affected users just need to bind once more after updating.

3. AFHDS2A offered as an external module type (regression from #3783)

AFHDS2A is the NV14 internal RF chip protocol. No external module speaks it, and the driver only handles the internal module. 4a79480 restricted it to the internal bay. When #3783 split FLYSKY into separate AFHDS2A and AFHDS3 types, the check became #if !defined(AFHDS2), so NV14 builds offered it for the external bay again.

Changes:

• isExternalModuleAvailable() now always rejects AFHDS2A.
• getModuleType() uses the same check, so existing models with the external bay set to AFHDS2A no longer start the driver there either.
• Removed the duplicated AFHDS3 check that came from the same split.
• Companion's external module/protocol lists no longer offer AFHDS2A.

Testing

• New tests/modules_helpers.cpp with regression tests for 2 and 3. They fail without the fixes and pass with them on nv14 and tx16s. Full tests-radio passes on both.
• NV14 firmware and simulator build.
• gtests-companion builds and passes.
• Tested on NV14 hardware: all three issues are resolved.
• Simulator: About page layout with normal and overflowing text.

Backport

Labelled backport/2.12. When backporting, the Companion hunk in commit 3 will probably need applying by hand, because moduledata.cpp has diverged between main and 2.12.

🤖 Generated with Claude Code