Skip to content

docs(lua): add luadoc annotations for the LVGL Lua API - #7837

Merged
pfeerick merged 2 commits into
EdgeTX:mainfrom
pfeerick:docs/lvgl-luadoc-annotations-main
Sep 28, 2026
Merged

pfeerick merged 2 commits into
EdgeTX:mainfrom
pfeerick:docs/lvgl-luadoc-annotations-main

Conversation

@pfeerick

@pfeerick pfeerick commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Port of #7771 to main. It adds /*luadoc*/ annotations for every lvgl.* constructor and utility function in radio/src/lua/api_colorlcd_lvgl.cpp, so the Lua reference doc pipeline can extract the LVGL API from source.

Why this is a straight cherry-pick

  • api_colorlcd_lvgl.cpp on main is byte-identical to 2.12 just before docs(lua): add luadoc annotations for the LVGL Lua API #7771 merged, so the patch applies cleanly. After the cherry-pick, the file matches 2.12 exactly.
  • lua_lvgl_widget.h is also identical. On main, lua_lvgl_widget.cpp only has internal refactors (include order, setWindowFlag(NO_CLICK / NO_FORCED_SCROLL), whitespace), and none of them add or remove a Lua-visible property.
  • The other Lua API additions on main (model.get/setSwitchWarning, model.*UserData, FUNC_DISABLE_KEYS) are outside LVGL and aren't affected.

The content is what was reviewed in #7771, and the version history in the @status lines applies to 3.0 unchanged.

Also included

  • Port of 2.12 commit 79719040d0: switches a few luadoc @retval field bullets in fstat, model.getInput and model.getSwashRing from straight single quotes ('trimSource') to the backtick style used everywhere else. It applied cleanly, and no single-quoted field bullets remain in main's Lua sources.

Test plan

  • LVGL commit: 854 additions and 0 deletions in a single file (comment-only, no behavior change)
  • Backtick commit: 12 lines changed in doc comments only
  • File is identical to origin/2.12:radio/src/lua/api_colorlcd_lvgl.cpp

🤖 Generated with Claude Code

Port of EdgeTX#7771 (2.12) to main. api_colorlcd_lvgl.cpp was identical on
main and on 2.12 just before EdgeTX#7771, so this is a clean, comment-only
cherry-pick that adds /*luadoc*/ blocks for every lvgl.* function.

(cherry picked from commit 8718d24)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pfeerick pfeerick added this to the 3.0 milestone Sep 28, 2026
@pfeerick pfeerick added documentation 📝 Improvements or additions to documentation lua labels Sep 28, 2026
Port of the 2.12 fix to main. A handful of @RetVal field-list bullets in
fstat, model.getInput, and model.getSwashRing quoted the field name with
straight single quotes ('trimSource') instead of the backtick style used
by every other luadoc annotation across the Lua API (`trimSource`).
Purely a doc-comment consistency fix, no functional change.

(cherry picked from commit 7971904)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@pfeerick
pfeerick marked this pull request as ready for review September 28, 2026 00:43
@pfeerick
pfeerick merged commit d351fdd into EdgeTX:main Sep 28, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📝 Improvements or additions to documentation lua

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant