Skip to content

Fail the build on translations whose placeholders drift #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpunto merged 2 commits into from
Sep 14, 2026
+8 −4
Merged

Fail the build on translations whose placeholders drift #6696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9d2d04
Fix malformed format specifiers in the docs and sample member count p…
gpunto Sep 11, 2026
96ac376
Fail the build on translations whose placeholders drift from the defa…
gpunto Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ subprojects {
lint.targetSdk = libs.versions.targetSdk.get().toInt()
testOptions.targetSdk = libs.versions.targetSdk.get().toInt()
}
// A translation whose placeholders drift from the default locale crashes at format time,
// so the report this check writes by default is too easy to miss.
lint.error += "StringFormatCount"
Comment thread
andremion marked this conversation as resolved.
}
}
pluginManager.withPlugin("com.android.application") {
Expand All @@ -98,6 +101,7 @@ subprojects {
minSdk = libs.versions.minSdk.get().toInt()
targetSdk = libs.versions.targetSdk.get().toInt()
}
lint.error += "StringFormatCount"
}
}

Expand Down
4 changes: 2 additions & 2 deletions stream-chat-android-docs/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<plurals name="members_count">
<item quantity="one">%1d Member</item>
<item quantity="other">%1d Members</item>
<item quantity="one">%1$d Member</item>
<item quantity="other">%1$d Members</item>
</plurals>
</resources>
4 changes: 2 additions & 2 deletions stream-chat-android-ui-components-sample/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@
<string name="add_group_channel_select_name_choose_title">NAME</string>
<string name="add_group_channel_select_name_choose_hint">Choose a group chat name</string>
<plurals name="members_count_title">
<item quantity="one">%1d Member</item>
<item quantity="other">%1d Members</item>
<item quantity="one">%1$d Member</item>
<item quantity="other">%1$d Members</item>
</plurals>
<string name="add_group_channel_select_name_create_button_title">Create</string>

Expand Down
Loading