Conversation
…s with the generated channel state models
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
…k server and the list endpoints share
3 tasks done
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Parse the channel state returned by
queryChannels,queryChanneland grouped channels with the generated models.Part of AND-1291
Implementation
QueryChannelsResponse,ChannelStateResponseandGroupedQueryChannelsResponse, and delete the hand-writtenQueryChannelsResponseandQueryGroupedChannelsResponse.PendingMessageResponse. Their metadata is server-side only and never sent to client-side callers, so it stays empty as before.Testing
E2E needs the mock server to send
durationon single channel queries, as the backend does (mock server PR to follow).MoshiChatApiTestcovers a channel state with every field set, the single-channel conversion, and a state without a channel. Before this, a recorded channel state was mapped through both the old and the new path and produced the sameChannel, including pending messages, hidden state, watchers and push preferences.On a device: queried a channel with pinned, quoted and thread messages, a reaction, a live location, a draft, reads and a push preference through
queryChannelandqueryChannels. Every field was set and both calls agreed. Hiding the channel returned the hidden flag and date, and offset pagination returned non-overlapping pages.🤖 Generated with Claude Code