Skip to content

Update README for Git practice - #14597

Closed
vaishuindukuri-create wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vaishuindukuri-create:my-first-change
Closed

Update README for Git practice#14597
vaishuindukuri-create wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
vaishuindukuri-create:my-first-change

Conversation

@vaishuindukuri-create

Copy link
Copy Markdown

This pull request updates the README as part of Git and GitHub practice.

Changes:

  • Added Git practice section to README

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 9, 2026
@google-cla

google-cla Bot commented Sep 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a personal practice section to the README.md file. The feedback advises against merging personal practice changes into a shared repository's documentation to keep it clean, and suggests adding a trailing newline to the file to comply with POSIX standards.

Comment thread README.md
Comment on lines +68 to +70
## My Git Practice

I created my first branch and made my first Git change. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This section appears to be for personal Git practice. To keep the repository documentation clean and relevant for all users, personal practice changes should not be merged into the main branch of a shared public repository. Consider practicing in a personal fork or scratch repository instead.

Comment thread README.md

## My Git Practice

I created my first branch and made my first Git change. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file does not end with a newline character. It is recommended to end all text files with a newline to comply with POSIX standards and avoid git warnings.

Suggested change
I created my first branch and made my first Git change.
I created my first branch and made my first Git change.

@XrossFox XrossFox closed this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants