Skip to content

March-dollase parameter update - #987

Open
saransh13 wants to merge 6 commits into
masterfrom
march-dollase
Open

saransh13 wants to merge 6 commits into
masterfrom
march-dollase

Conversation

@saransh13

@saransh13 saransh13 commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

The parameter P_MD in MarchDollase class was not getting updated correctly. This pull fixes it and is needed for HEXRD/hexrdgui#2061

@saransh13
saransh13 requested a review from psavery October 3, 2026 21:13
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.39%. Comparing base (073fd14) to head (7eaaf58).

Files with missing lines Patch % Lines
hexrd/powder/wppf/WPPF.py 63.04% 17 Missing ⚠️
hexrd/core/projections/polar.py 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   75.45%   75.39%   -0.07%     
==========================================
  Files         149      149              
  Lines       22961    23006      +45     
==========================================
+ Hits        17325    17345      +20     
- Misses       5636     5661      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant