Skip to content

CancellableRequest missleading naming #61

Description

@mrylmz

The public interface of the CancellableRequest only includes a cancel method and an identifier. It doesn't contain any informations about a request and is also only intended to be used for a request cancellation.

My suggestion is to rename the CancellableRequest into CancellationToken, RequestToken or define a proper interface to represent a non opaque request.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions