Give tracked reals with a free origin a zero and a one (fixes #172), and pin #126 - #302
Merged
Merged
Conversation
`gradient(x -> x[], fill(1.0))` threw a `MethodError` for an ambiguity between the `AbstractRange...` and `Colon...` methods of `getindex`: a bare vararg matches zero arguments, so `t[]` matched both equally. 4a50321 fixed it incidentally while fixing #202, by rewriting every `getindex(t::TrackedArray, i::T...)` as `i1::T, is::T...`. Requiring a leading index sends `t[]` down `Base`'s generic zero-index `AbstractArray` path, which lands on the `Integer` method via linear indexing -- so, like any scalar `getindex`, it aliases its parent through the origin and records nothing. Nothing pinned that, and the ambiguity would come back unnoticed with any future widening of those signatures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`map`ping over a tracked array mixes elements that carry an origin with ones
that do not, and the resulting eltype leaves the origin free. `reducedim_init`
allocates a reduction's accumulator by asking that eltype for its `zero`, or
`one` for `prod`, which fell through to `convert(T, 0)` and then to `valtype`,
defined only for a pinned origin:
MethodError: no method matching valtype(::Type{TrackedReal{Float64, Float64}})
Neither identity depends on the origin, so both are deducible from the type
alone, as `zero` requires. `Nothing` is the origin `zero` has always used, and
`TrackedReal{V,D,Nothing}` is an instance of `TrackedReal{V,D}`, so the
documented `zero(T) isa T` holds. The signature matches that type exactly
rather than its subtypes: a `Union` of two origins is also a subtype, and no
single member of it could be returned.
The `zero` method is the one #173 added and #177 reverted wholesale over #175,
whose cause -- `increment_deriv!` indexing into untracked elements -- was fixed
by #300. `one` is its counterpart, which #173 never added.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 86.92% 86.93% +0.01%
==========================================
Files 19 19
Lines 1950 1952 +2
==========================================
+ Hits 1695 1697 +2
Misses 255 255 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#301 triaged #126 and #172 as already passing on master. #126 does; #172 does not, so this branch pins the first and fixes the second.
#126 — test only
gradient(x -> x[], fill(1.0))was ambiguous between theAbstractRange...andColon...methods ofgetindex, because a bare vararg matches zero arguments.4a50321fixed it incidentally while fixing #202, by requiring a leading index. Nothing pinned it, and it would come back unnoticed with any future widening of those signatures.#172 — fix and test
mapping over a tracked array mixes elements that carry an origin with ones that do not, and the resulting eltype leaves the origin free.reducedim_initallocates a reduction's accumulator by asking that eltype for itszero, oroneforprod, which reachedvaltype— defined only for a pinned origin:That is the element type in the issue's stack trace. Narrower spellings of "different types" (
Real[],Any[]) already worked, which is most likely what produced the triage in #301.Neither identity depends on the origin, so both are deducible from the type alone, as
zerorequires.Nothingis the originzerohas always used, andTrackedReal{V,D,Nothing}is an instance ofTrackedReal{V,D}, so the documentedzero(T) isa Tholds. The signature matches that type exactly rather than its subtypes: aUnionof two origins is also a subtype, and no single member of it could be returned.The
zeromethod is the one #173 added and #177 reverted wholesale over #175, whose cause —increment_deriv!indexing into untracked elements — was fixed by #300.oneis its counterpart, which #173 never added.Derivatives still route through the tape, not the origin: the accumulator is a fresh value, never an aliased array slot. Checked against ForwardDiff across randomized
sum/prodreductions,jacobianandhessian, and on tape replay with a compiled tape — the committed test usesprodso that a replay reusing stale values would be caught.detect_ambiguities(ReverseDiff)is unchanged at 877, none involvingzeroorone. Removing the two methods makes every new #172 assertion fail with theMethodErrorabove, and leaves the #126 ones passing.🤖 Generated with Claude Code