Pin +/- with untracked elements (closes #175) - #306
Merged
Merged
Conversation
`Diagonal` and `diagm` of a `Vector{Real}` give tracked diagonal entries
and untracked zeros, whose reverse pass threw `increment_deriv!(::Float64,
::Float64)` until #300 made it skip untracked elements. Check against the
analytical Jacobians, directly and on a compiled tape.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #306 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 19 19
Lines 1934 1934
=======================================
Hits 1706 1706
Misses 228 228 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#175 was fixed by #300 and nothing pins it.
Diagonal/diagmof aVector{Real}gives tracked diagonal entries and untracked zeros, and the reverse pass of+/-threwincrement_deriv!(::Float64, ::Float64)on the zeros until #300 made it skip untracked elements.The new testset checks
+/-with such matrices, in both argument orders, against the analytical Jacobians, directly and on a compiled tape. The same reproducer throws the #175 error before #300 (e127522~1) and passes from #300 on.🤖 Generated with Claude Code