security: remove hardcoded Sentry DSN from source - #153
Open
SomSatwik wants to merge 3 commits into
Open
Conversation
The Sentry DSN (ingest authentication key) was embedded as a plaintext
string literal in src/util/util_sentry.cpp. Anyone reading the public
GitHub repository or stripping the shipped DLL could extract it and:
- Spam the NVIDIA Sentry project with forged crash events, exhausting
the quota and drowning real reports in noise.
- Incur billing charges on NVIDIA's Sentry account.
- Enumerate project metadata via the Sentry ingest API.
Fix: move the DSN out of source entirely. A new Meson option
'remix_sentry_dsn' (analogous to the existing 'remix_sentry_environment')
is passed to the compiler as -DREMIX_SENTRY_DSN=<dsn>. CI release
builds supply the value from a secrets store; local/dev builds that omit
the option compile with an empty string, which sentry-native silently
treats as a no-op (crash upload is disabled).
The now-public DSN must be rotated in the Sentry dashboard.
OWASP: A07:2021 - Identification and Authentication Failures
CWE-798: Use of Hard-coded Credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sentry DSN (ingest authentication key) was embedded as a plaintext string literal in src/util/util_sentry.cpp. Anyone reading the public GitHub repository or stripping the shipped DLL could extract it and:
Fix: move the DSN out of source entirely. A new Meson option 'remix_sentry_dsn' (analogous to the existing 'remix_sentry_environment') is passed to the compiler as -DREMIX_SENTRY_DSN=. CI release builds supply the value from a secrets store; local/dev builds that omit the option compile with an empty string, which sentry-native silently treats as a no-op (crash upload is disabled).
The now-public DSN must be rotated in the Sentry dashboard.
OWASP: A07:2021 - Identification and Authentication Failures
CWE-798: Use of Hard-coded Credentials