Skip to content

Pin versions of Docker images, update comment - #1294

Open
kinow wants to merge 1 commit into
NatLibFi:skosmos-2from
kinow:pin-docker-image-versions
Open

kinow wants to merge 1 commit into
NatLibFi:skosmos-2from
kinow:pin-docker-image-versions

Conversation

@kinow

@kinow kinow commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator

Reasons for creating this PR

From the linked discussion, looks like Varnish changed the image and now it cannot be used with its default port 80. This pull request pins the versions of the images, instead of using the latest tag, in Docker Compose.

Also updates the commented text to avoid YAML errors.

Link to relevant issue(s), if any

Description of the changes in this PR

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@sonarqubecloud

sonarqubecloud Bot commented Apr 5, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@codecov

codecov Bot commented Apr 5, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.68%. Comparing base (5d193c2) to head (e234938).
⚠️ Report is 221 commits behind head on skosmos-2.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-2    #1294   +/-   ##
============================================
  Coverage        70.68%   70.68%           
  Complexity        1646     1646           
============================================
  Files               32       32           
  Lines             3786     3786           
============================================
  Hits              2676     2676           
  Misses            1110     1110           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kinow

kinow commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator Author

Also added some troubleshooting notes to the Wiki: https://github.com/NatLibFi/Skosmos/wiki/Install-Skosmos-with-Fuseki-in-Docker#troubleshooting

@kinow
kinow force-pushed the pin-docker-image-versions branch from b82a7a2 to e234938 Compare May 24, 2022 09:04
@kinow

kinow commented May 24, 2022

Copy link
Copy Markdown
Collaborator Author

Rebased.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant