Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## skosmos-2 #1294 +/- ##
============================================
Coverage 70.68% 70.68%
Complexity 1646 1646
============================================
Files 32 32
Lines 3786 3786
============================================
Hits 2676 2676
Misses 1110 1110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Also added some troubleshooting notes to the Wiki: https://github.com/NatLibFi/Skosmos/wiki/Install-Skosmos-with-Fuseki-in-Docker#troubleshooting |
kinow
force-pushed
the
pin-docker-image-versions
branch
from
May 24, 2022 09:04
b82a7a2 to
e234938
Compare
Collaborator
Author
|
Rebased. |
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Reasons for creating this PR
From the linked discussion, looks like Varnish changed the image and now it cannot be used with its default port
80. This pull request pins the versions of the images, instead of using thelatesttag, in Docker Compose.Also updates the commented text to avoid YAML errors.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Checklist