[16.0][I18N] shopfloor_mobile_*: add fr translations - #1281
Open
nicolas-delbovier-acsone wants to merge 6 commits into
Open
nicolas-delbovier-acsone wants to merge 6 commits into
nicolas-delbovier-acsone wants to merge 6 commits into
Conversation
OCA-git-bot
added
series:16.0
mod:shopfloor_reception_mobile
Contributor
|
Hi @TDu, @rousseldenis, @simahawk, @JuMiSanAr, |
nicolas-delbovier-acsone
force-pushed
the
16.0-i18n-shopfloor_mobile-add-fr-translations
branch
from
September 18, 2026 12:49
6c30737 to
ee5573d
Compare
Author
|
@sebalix Jacques told me to ping you on this one. Any thoughts about the way I suggest to translate? |
rousseldenis
approved these changes
Sep 21, 2026
nicolas-delbovier-acsone
marked this pull request as draft
September 21, 2026 09:59
Author
|
For the record, I've been convinced by @simahawk to keep using keys for translations instead of plain English strings. I'll change this PR to use this approach. |
nicolas-delbovier-acsone
force-pushed
the
16.0-i18n-shopfloor_mobile-add-fr-translations
branch
2 times, most recently
from
September 21, 2026 14:27
ef7c8c9 to
3081505
Compare
nicolas-delbovier-acsone
marked this pull request as ready for review
September 22, 2026 08:21
lmignon
suggested changes
Sep 23, 2026
nicolas-delbovier-acsone
force-pushed
the
16.0-i18n-shopfloor_mobile-add-fr-translations
branch
from
September 23, 2026 09:01
3081505 to
d451e19
Compare
lmignon
suggested changes
Sep 23, 2026
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
What a big job.... unfortunately one translation is missing..
lmignon
approved these changes
Sep 23, 2026
rousseldenis
approved these changes
Sep 23, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I did not follow the convention for the translation keys for new translations.IMO, Natural Language translation keys are better because they provide a better fallback in case of error (you do not see "btn.confirm" in case the registery got a problem/your venv is not up to date etc.). This is closer to what we do in odoo with_("Some String").This is also easier to dev as you see directly inside one file what the user sees (no need to openi18n/en.jsonto see what is displayed).We can follow the convention to always use English in the .js files and only provide translation files for other languages (thus getting rid of all unnecessaryen.jsonfiles).=> I've been convinced to use labels instead of raw English strings because this makes the translations more resilient to code changes.
cc @jbaudoux