fix: [SDK-5304] reject null and empty identity strings instead of crashing

[abdulraqeeb33]

Description

One Line Summary

Return from React Native identity string APIs when the value is null or empty instead of crashing Kotlin non-null String parameters.

Details

Motivation

Fixes SDK-5304. JS null reaches Kotlin OneSignal.login(externalId: String) (and the same class of APIs: addEmail, initialize(appId)), which throws IllegalArgumentException: Parameter specified as non-null is null. The TurboModule method is void and uncaught, so the host process dies.

Empty string does not NPE, but login("") is not a valid user id. Rejected in the same helper.

Other SDKs: SDK-5327.

Scope

isNonEmptyString rejects null, undefined, and empty for:

• initialize(appId)
• login(externalId)
• addAlias (label and id) and removeAlias
• addEmail / removeEmail
• addSms / removeSms
• addTag (key only). An empty tag value is allowed. A null tag value is rejected. removeTag rejects an empty key.
• addTrigger (key only). An empty trigger value is allowed. A null trigger value is rejected. addTrigger returns after the invalid-input log instead of still calling native. removeTrigger rejects an empty key.

Native login also returns on null/nil or empty. Public TS types stay string.

setLanguage("") is not rejected. It is the reset to the device language, and there is no other reset path. null is still rejected.

addAliases, removeAliases, addTags, removeTags, addTriggers, removeTriggers, and trackEvent are unchanged.

Testing

Unit testing

vp test: 291 tests passed. Covers login/initialize/addEmail null and empty, setLanguage("") still calling native, null language not calling native, and addTrigger no longer calling native after invalid input.

Manual testing

Not run on a device. The crash is a null argument at the bridge. Unit coverage is the JS helper. Native login guards match null/empty.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

[nan-li]

We have login(externalId: string) defined as string instead of optional string in the API:

react-native-onesignal/src/index.ts

Line 122 in 11cab78

export function login(externalId: string) {

Maybe we can do the check there instead of at both bridges, like we do for addTag where we check:

      if (!key || value === undefined || value === null) {
        console.error('OneSignal: addTag: must include a key and a value');
        return;
      }

Are there other methods where devs are submitting invalid inputs that can crash?

[abdulraqeeb33]

We have login(externalId: string) defined as string instead of optional string in the API:

react-native-onesignal/src/index.ts

Line 122 in 11cab78

export function login(externalId: string) {

Maybe we can do the check there instead of at both bridges, like we do for addTag where we check:

      if (!key || value === undefined || value === null) {
        console.error('OneSignal: addTag: must include a key and a value');
        return;
      }

Are there other methods where devs are submitting invalid inputs that can crash?

Good cal @nan-li - updated it in other methods as well. please check it out.

[fadi-george]

can just be !appId , similar in other places

[abdulraqeeb33]

Kept isNonEmptyString. !appId lets a non-string through, and it would reject "" for tag values, trigger values, and setLanguage.

[fadi-george]

id make the empty string changes a separate ticket and get agreement on changing for all sdks

[abdulraqeeb33]

Empty string stays in this PR. Parent is SDK-5327, with a subtask per SDK.

setLanguage("") stays allowed (ada0ef6). It resets Android and iOS to the device language.