Skip to content

F #-: Add GRE module to VRouter - #397

Open
vichansson wants to merge 1 commit into
masterfrom
f-vr-gre
Open

vichansson wants to merge 1 commit into
masterfrom
f-vr-gre

Conversation

@vichansson

Copy link
Copy Markdown
  • Add GRE tunnel support to VRouter

  • Validate configuration, enable tunnel forwarding, and order startup after Router4 and sysctl

  • Add GRE functionality tests

  • Format/Lint changes in appliances/VRouter/Failover/execute.rb

* Update tests
* Fix forwarding enable
* Fix startup ordering

Signed-off-by: Victor Hansson <vhansson@opennebula.io>
@vichansson
vichansson requested a review from rsmontero September 7, 2026 10:57
@rsmontero rsmontero added this to the Release 7.6.0 milestone Sep 7, 2026
@rsmontero
rsmontero requested a review from xorel September 7, 2026 11:07

module Service
module Failover
module Failover

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep 4 spaces everywhere, I thought it's kind of dogma

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • let's try to avoid white-space only changes pls

@xorel xorel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the indent, I think the policy routing sends too much into the tunnel.

The from rule makes every packet from that block use table 10000, which only has the throw for the block itself plus the tunnel default, so the main table is never consulted.

A public VM talking to a private VM behind the same VR, or to anything reached via a static or ONEGATE route, ends up in the tunnel.

my agent suggest this:

The usual fix is a rule from lookup main suppress_prefixlength 0 before the table 10000 rule, same pattern wg-quick uses, which lets main answer for everything except its default route. The throw routes then are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants