Update feather-tk to the latest - #63
Merged
Merged
Conversation
CMake 3.31 refuses to generate the toucanRenderTargets export while toucanRender links a target that is not exported, so a static build no longer configured. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Follows the API as it stands on feather-tk main (d673afd): - ObservableValue and ValueObserver are Observable and Observer, and the command line classes drop the Value and Flag qualifiers. - Widgets report their size through a virtual getSizeHint() instead of storing it from sizeHintEvent(). Wrappers return the child's hint; the widgets that measure themselves keep the measurement in sizeHintEvent() and hand it back from getSizeHint(). - Action shortcuts are KeyShortcut values and mouse buttons are an enum. - The app owns the display scale, so the Window menu sets it on the app, and the persisted value is applied only when one was saved: zero no longer means automatic. - The app owns the settings and log files, named by AppFiles, so toucan-view drops its own Settings object. - File drops arrive as a dropEvent() carrying DragDropTextData. - Enum settings are parsed with from_string(); the stream extraction operator is gone. - The recent files model and the file browser use ftk::Path. - IApp has no getExit() or run(): a parse problem throws, and hasCmdLineHelp() says when the help was printed instead. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Both tools show the timeline selection, so they were blank after a file opened until something was clicked. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @leighsmith for the initial investigation.
Assisted-by: Claude:claude-fable-5-1 [patch] [debugging]