Skip to content

fix: PDF import header matching; dependency and import cleanup - #55

Merged
PPeitsch merged 1 commit into
mainfrom
chore/cleanup
Oct 3, 2026
Merged

PPeitsch merged 1 commit into
mainfrom
chore/cleanup

Conversation

@PPeitsch

@PPeitsch PPeitsch commented Oct 3, 2026

Copy link
Copy Markdown
Owner

Last cleanup before the release, from the code review.

  • PDF import (C12): column headers are matched by whole word. Before, any header containing "in" / "out" ("Login method", "Checkout notes") was taken as the entry or exit column and could override the real one. New test fails on the old code.
  • M3: beautifulsoup4 pinned to the stable 4.13.4 instead of 4.13.0b2.
  • M7: app.routes exports every blueprint.
  • Unused imports removed from app/routes/import_log.py.

- Headers like "Login method" were taken as the entry column because
  they contain "in" (review C12).
- beautifulsoup4 pinned to stable 4.13.4 instead of a beta (M3).
- app.routes exports every blueprint (M7); unused imports removed from
  import_log.
@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Files with missing lines Coverage Δ
app/routes/__init__.py 100.00% <100.00%> (ø)
app/routes/import_log.py 91.71% <100.00%> (-0.26%) ⬇️
app/services/importer/pdf_importer.py 95.12% <100.00%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PPeitsch
PPeitsch merged commit 4016b7b into main Oct 3, 2026
3 checks passed
@PPeitsch
PPeitsch deleted the chore/cleanup branch October 3, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant