Update code coverage report to always add comment even if failures - #1714
Open
Steve Lee (SteveL-MSFT) wants to merge 1 commit into
Open
Update code coverage report to always add comment even if failures#1714Steve Lee (SteveL-MSFT) wants to merge 1 commit into
Steve Lee (SteveL-MSFT) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal and correctly uses a job-level always() condition to prevent the coverage-report job from being skipped when upstream jobs fail.
Pull request overview
This PR updates the Rust CI workflow so the coverage-report job still runs on pull requests even when upstream needs jobs fail, ensuring the PR coverage comment is posted consistently.
Changes:
- Update
coverage-reportjob condition to usealways()gated bygithub.event_name == 'pull_request', preventing the job from being skipped due to failed dependencies.
File summaries
| File | Description |
|---|---|
| .github/workflows/rust.yml | Ensures the PR coverage comment job runs even if required build/test jobs fail by using a job-level always() condition. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
always()to ensure the CC comment always gets added for PR even if test/build failures