Relicense to GPL (>= 2); opaque case IDs and sealed evaluator truth - #3
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relicenses VariantStoryBench to GPL (>= 2), in line with RGenomicsETL's policy (all copyright holders agreed), and makes the benchmark's inputs safe to hand to an engine. The history is kept.
DESCRIPTIONnow readsGPL (>= 2).LICENSEcarries the full GPL-2 text and is left out of the package build (.Rbuildignore), soR CMD checkdoesn't raise a NOTE. The README is re-rendered and NEWS records the change.bench_manifest_paths()now has one.test-generation.Ruses it for an optional round trip through four VCFs; that path was not run locally.The opaque IDs are not a security boundary against an engine that can read this package's source. Isolation relies on giving the adapter only the engine bundle.
Checks:
R CMD check --no-manualon the built tarball: Status OK.make targets: all six targets complete offline from a fresh store.Performance
No checked-in benchmark covers these changes. They rename fixture identifiers and change output directories; no data paths are measured.