Skip to content

Relicense to GPL (>= 2); opaque case IDs and sealed evaluator truth - #3

Merged
sounkou-bioinfo merged 5 commits into
mainfrom
cleanup/gpl2-sealed-truth
Sep 28, 2026
Merged

sounkou-bioinfo merged 5 commits into
mainfrom
cleanup/gpl2-sealed-truth

Conversation

@sounkou-bioinfo

Copy link
Copy Markdown
Member

Relicenses VariantStoryBench to GPL (>= 2), in line with RGenomicsETL's policy (all copyright holders agreed), and makes the benchmark's inputs safe to hand to an engine. The history is kept.

  • Licence: DESCRIPTION now reads GPL (>= 2). LICENSE carries the full GPL-2 text and is left out of the package build (.Rbuildignore), so R CMD check doesn't raise a NOTE. The README is re-rendered and NEWS records the change.
  • Opaque case IDs: generated cases and fixtures get stable identifiers derived from the seed and case index, so a file name can't reveal a case's role (for example "confirmed negative"). The mapping from ID to role is kept only in the evaluator's truth.
  • Sealed truth: engine inputs and evaluator truth are written to separate directories. A test checks that the engine bundle contains no truth relation or truth-derived column.
  • Tests: bench_manifest_paths() now has one.
  • CI: the pinned Rduckhts install stays. test-generation.R uses it for an optional round trip through four VCFs; that path was not run locally.

The opaque IDs are not a security boundary against an engine that can read this package's source. Isolation relies on giving the adapter only the engine bundle.

Checks:

  • R CMD check --no-manual on the built tarball: Status OK.
  • tinytest: 195 passed, 0 failed.
  • make targets: all six targets complete offline from a fresh store.

Performance

No checked-in benchmark covers these changes. They rename fixture identifiers and change output directories; no data paths are measured.

Prepared with Claude 5.5 and GPT 6 Sol in Claude Code and Pi

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T19:55:00.636507Z bac8a8c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sounkou-bioinfo
sounkou-bioinfo merged commit 040a031 into main Sep 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant