Skip to content

tests: migrate KCM to system tests - #9159

Merged
justin-stephenson merged 1 commit into
SSSD:masterfrom
krishnavema:migrate-kcm-system-tests
Sep 14, 2026
Merged

justin-stephenson merged 1 commit into
SSSD:masterfrom
krishnavema:migrate-kcm-system-tests

Conversation

@krishnavema

@krishnavema krishnavema commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

tests: Migrate the legacy bash/beakerlib KCM suite (bash/krb_provider/kcm, 27 cases) to pytest system tests in test_kcm.py

Co-authored-by: Cursor cursoragent@cursor.com
Model used: Claude Opus 4.8

@alexey-tikhonov

Copy link
Copy Markdown
Member

@krishnavema,

  1. is this migration from bash or multihost tests?
  2. is it LLM-assisted? In this case please mention this in the commit message.

@alexey-tikhonov

Copy link
Copy Markdown
Member

Please set backport-to-* labels as needed.

@krishnavema

Copy link
Copy Markdown
Contributor Author

@krishnavema,

  1. is this migration from bash or multihost tests?
  2. is it LLM-assisted? In this case please mention this in the commit message.

It's migrated from the bash suite

@krishnavema

krishnavema commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Please set backport-to-* labels as needed.

done

Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py Outdated
@madhuriupadhye

Copy link
Copy Markdown
Contributor

Thanks for the migration work. I compared this against the legacy bash suite in
sssd-qe/client/krb_provider/kcm/kcm (27 Beaker cases) for IDM-7741.

Requesting changes before merge:

  1. Once System CI is green, please cross verify with IDM-CI also
  2. Add a bash→pytest mapping table in the MR (all 27 cases: ported / partial / missing / deferred).
  3. Add LLM disclosure to the commit message (not just PR body), per Alexey’s comment.
  4. Several legacy cases are missing or only partially ported — see inline comments.

Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py Outdated
Comment thread src/tests/system/tests/test_kcm.py
Comment thread src/tests/system/tests/test_kcm.py
@krishnavema
krishnavema force-pushed the migrate-kcm-system-tests branch 2 times, most recently from 2f052da to 4f85602 Compare September 3, 2026 17:03

@madhuriupadhye madhuriupadhye left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Before merging, please check with IDMCI as well. Also, please create a downstream MR to delete it or at least remove it from qualification so the job doesn't run in any pipeline.

@madhuriupadhye
madhuriupadhye self-requested a review September 12, 2026 06:27
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
@sssd-bot

Copy link
Copy Markdown
Contributor

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-45-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 testing-farm:fedora-43-x86_64:upstream (success)
🔴 testing-farm:fedora-44-x86_64:upstream (failure)
🔴 testing-farm:fedora-45-x86_64:upstream (failure)
🔴 testing-farm:fedora-rawhide-x86_64:upstream (failure)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / intgcheck (fedora-45) (success)
🟢 ci / intgcheck (fedora-46) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
🟢 ci / system (fedora-45) (success)
🟢 ci / system (fedora-46) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / files-changed (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the migrate-kcm-system-tests branch from 4f85602 to 48a55a3 Compare September 14, 2026 12:36
@justin-stephenson

Copy link
Copy Markdown
Contributor

Looks good to me. Before merging, please check with IDMCI as well. Also, please create a downstream MR to delete it or at least remove it from qualification so the job doesn't run in any pipeline.

@krishnavema Please check this then merge once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants