[autobackport: sssd-2-9] tests: convert multihost failover and connection timeout tests to sys… - #9240
Conversation
justin-stephenson
left a comment
There was a problem hiding this comment.
@aborah-sudo Please fix conflicts here
370c09d to
43fb404
Compare
justin-stephenson
left a comment
There was a problem hiding this comment.
System tests failure is unrelated
FAILED tests/test_failover.py::test_failover__connect_using_ipv4_second_family (ipa) - AssertionError: testuser was not found, SSSD did not switch to IPv4 family!
spoore1
left a comment
There was a problem hiding this comment.
Looks like the one test case is failing in CentOS 10:
FAILED tests/test_failover.py::test_failover__connect_using_ipv4_second_family (ipa) - AssertionError: testuser was not found, SSSD did not switch to IPv4 family!
assert None is not None
= 1 failed, 478 passed, 50 skipped, 205 deselected, 1 xfailed, 2 warnings in 5872.16s (1:37:52) =
While this case is not a new addition (from the diff anyway), it is adjacent to the updates from this PR. Can this be fixed or should this test case not be included?
43fb404 to
9adc23d
Compare
Please refer @justin-stephenson comment : #9240 (review) Also this tests was not part of original #9160, it was never back ported to this branch, so i have removed this test from this backport |
9adc23d to
8794cac
Compare
spoore1
left a comment
There was a problem hiding this comment.
LGTM. Test failures not related to this change:
FAILED tests/test_access_control_simple.py::test_access_control_simple__deny_group_supersedes_allow_group (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file
2633
FAILED tests/test_authentication.py::test_authentication__user_login[root-ssh] (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file
2634
FAILED tests/test_authentication.py::test_authentication__user_login_then_changes_password (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file
…tem tests Convert legacy multihost tests from src/tests/multihost/alltests/ to sssd-test-framework system tests: - test_failover.py test_0002_login: add login-via-backup test that fills the auth gap not covered by the existing reactivation_timeout test (BZ 1283798). test_0001_getent and test_0003_stopsecondds are already covered by existing system tests. - test_krb_ldap_connection.py (5 tests): ldap_connection_expire_timeout validation including default value logging, connection recycling for custom/zero/negative values, and out-of-range rejection. Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Scott Poore <spoore@redhat.com> (cherry picked from commit 0f15e06)
|
The pull request was accepted by @spoore1 with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
8794cac to
91267bc
Compare
This is an automatic backport of PR#9160 tests: convert multihost failover and connection timeout tests to sys… to branch sssd-2-9, created by @aborah-sudo.
Caution
@aborah-sudo The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
0f15e06 - tests: convert multihost failover and connection timeout tests to system tests
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body
…tem tests
Convert legacy multihost tests from src/tests/multihost/alltests/ to sssd-test-framework system tests: