Skip to content

[autobackport: sssd-2-9] tests: convert multihost failover and connection timeout tests to sys… - #9240

Merged
justin-stephenson merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr9160-to-sssd-2-9
Sep 15, 2026
Merged

justin-stephenson merged 1 commit into
SSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr9160-to-sssd-2-9

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#9160 tests: convert multihost failover and connection timeout tests to sys… to branch sssd-2-9, created by @aborah-sudo.

Caution

@aborah-sudo The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr9160-to-sssd-2-9
git checkout SSSD-sssd-backport-pr9160-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr9160-to-sssd-2-9 --force

Original commits
0f15e06 - tests: convert multihost failover and connection timeout tests to system tests

Backported commits

  • 370c09d - CONFLICT! tests: convert multihost failover and connection timeout tests to system tests

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! tests: convert multihost failover and connection timeout tests to system tests
On branch SSSD-sssd-backport-pr9160-to-sssd-2-9
You are currently cherry-picking commit 0f15e0624.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/tests/multihost/alltests/conftest.py
	deleted:    src/tests/multihost/alltests/test_failover.py
	deleted:    src/tests/multihost/alltests/test_krb_ldap_connection.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_failover.py
	both modified:   src/tests/system/tests/test_ldap.py

Original Pull Request Body

…tem tests

Convert legacy multihost tests from src/tests/multihost/alltests/ to sssd-test-framework system tests:

  • test_failover.py test_0002_login: add login-via-backup test that fills the auth gap not covered by the existing reactivation_timeout test (BZ 1283798). test_0001_getent and test_0003_stopsecondds are already covered by existing system tests.
  • test_krb_ldap_connection.py (5 tests): ldap_connection_expire_timeout validation including default value logging, connection recycling for custom/zero/negative values, and out-of-range rejection.

Comment thread src/tests/system/tests/test_failover.py Fixed
Comment thread src/tests/system/tests/test_ldap.py Fixed

@justin-stephenson justin-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aborah-sudo Please fix conflicts here

@aborah-sudo
aborah-sudo force-pushed the SSSD-sssd-backport-pr9160-to-sssd-2-9 branch from 370c09d to 43fb404 Compare September 9, 2026 05:43
@aborah-sudo
aborah-sudo marked this pull request as ready for review September 9, 2026 05:43

@justin-stephenson justin-stephenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests failure is unrelated

FAILED tests/test_failover.py::test_failover__connect_using_ipv4_second_family (ipa) - AssertionError: testuser was not found, SSSD did not switch to IPv4 family!

@spoore1 spoore1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the one test case is failing in CentOS 10:

FAILED tests/test_failover.py::test_failover__connect_using_ipv4_second_family (ipa) - AssertionError: testuser was not found, SSSD did not switch to IPv4 family!
assert None is not None
= 1 failed, 478 passed, 50 skipped, 205 deselected, 1 xfailed, 2 warnings in 5872.16s (1:37:52) =

While this case is not a new addition (from the diff anyway), it is adjacent to the updates from this PR. Can this be fixed or should this test case not be included?

@aborah-sudo
aborah-sudo force-pushed the SSSD-sssd-backport-pr9160-to-sssd-2-9 branch from 43fb404 to 9adc23d Compare September 11, 2026 04:25
@aborah-sudo
aborah-sudo requested a review from spoore1 September 11, 2026 04:26
@aborah-sudo

Copy link
Copy Markdown
Contributor

Looks like the one test case is failing in CentOS 10:

FAILED tests/test_failover.py::test_failover__connect_using_ipv4_second_family (ipa) - AssertionError: testuser was not found, SSSD did not switch to IPv4 family!
assert None is not None
= 1 failed, 478 passed, 50 skipped, 205 deselected, 1 xfailed, 2 warnings in 5872.16s (1:37:52) =

While this case is not a new addition (from the diff anyway), it is adjacent to the updates from this PR. Can this be fixed or should this test case not be included?

Please refer @justin-stephenson comment : #9240 (review)

Also this tests was not part of original #9160, it was never back ported to this branch, so i have removed this test from this backport

@aborah-sudo
aborah-sudo force-pushed the SSSD-sssd-backport-pr9160-to-sssd-2-9 branch from 9adc23d to 8794cac Compare September 11, 2026 04:54

@spoore1 spoore1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures not related to this change:

FAILED tests/test_access_control_simple.py::test_access_control_simple__deny_group_supersedes_allow_group (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file
2633
FAILED tests/test_authentication.py::test_authentication__user_login[root-ssh] (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file
2634
FAILED tests/test_authentication.py::test_authentication__user_login_then_changes_password (ldap) - sssd_test_framework.misc.errors.ExpectScriptError: Unexpected end of file

@spoore1 spoore1 added Accepted no-backport This should go to target branch only. labels Sep 14, 2026
…tem tests

Convert legacy multihost tests from src/tests/multihost/alltests/ to
sssd-test-framework system tests:

- test_failover.py test_0002_login: add login-via-backup test that fills
  the auth gap not covered by the existing reactivation_timeout test
  (BZ 1283798). test_0001_getent and test_0003_stopsecondds are already
  covered by existing system tests.
- test_krb_ldap_connection.py (5 tests): ldap_connection_expire_timeout
  validation including default value logging, connection recycling for
  custom/zero/negative values, and out-of-range rejection.

Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit 0f15e06)
@sssd-bot

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🔴 testing-farm:centos-stream-9-x86_64:upstream (failure)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🔴 ci / system (centos-9) (failure)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / files-changed (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot
sssd-bot force-pushed the SSSD-sssd-backport-pr9160-to-sssd-2-9 branch from 8794cac to 91267bc Compare September 14, 2026 21:08
@justin-stephenson
justin-stephenson merged commit 46712d8 into SSSD:sssd-2-9 Sep 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants