Retry a failed floxi chat completion once - #1435
Merged
Merged
Conversation
GetChatCompletions now sends the request a second time when the first attempt fails, whatever the status and whether the transport answered or threw. A dispatch usually lands on a different node the second time, so a failure the request itself did not cause tends not to repeat. A cancelled request is never retried: the caller has stopped waiting, so a second dispatch would only spend a node on a reply nobody will read. The streaming path is untouched - once a delta has reached the client a retry would append a whole second reply to what it is already rendering. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…ature/floxi-chat-retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetChatCompletions now sends the request a second time when the first attempt fails, whatever the status and whether the transport answered or threw. A dispatch usually lands on a different node the second time, so a failure the request itself did not cause tends not to repeat.
A cancelled request is never retried: the caller has stopped waiting, so a second dispatch would only spend a node on a reply nobody will read.
The streaming path is untouched - once a delta has reached the client a retry would append a whole second reply to what it is already rendering.