Repository navigation
syncany-cli: Switch to GitHub releases - #8629
Conversation
|
/verify |
|
All changes look good. Wait for review from human collaborators. syncany-cli
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Summary by CodeRabbit
WalkthroughThe Syncany CLI manifest now uses the GitHub repository for its homepage and release assets. It checks the latest GitHub release tag to determine the version. ChangesSyncany release sources
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to Version checks can fail after the unauthenticated GitHub quota is exhausted, even when an operator configured a token. This is a localized manifest fix; the installer URL’s availability remains unverified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
9de7cc71-89ea-4d44-b8c4-f3a679daab9e
📒 Files selected for processing (1)
bucket/syncany-cli.json
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
| "checkver": { | ||
| "url": "https://get.syncany.org/dist/releases/?C=M;O=D", | ||
| "regex": "syncany-cli-([\\d.]+)-alpha\\.exe" | ||
| "url": "https://api.github.com/repos/syncany/syncany/releases", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Use checkver.github for the release API URL.
With checkver.url, Scoop does not send a configured GitHub token to this API endpoint. A rate-limited check can therefore fail even when the operator has configured a token. Change the key to github; Scoop accepts this API URL and retains the explicit jsonpath and regex. (github.com)
Proposed change
- "url": "https://api.github.com/repos/syncany/syncany/releases",
+ "github": "https://api.github.com/repos/syncany/syncany/releases",Based on learnings, an API-style URL is valid in checkver.github.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "url": "https://api.github.com/repos/syncany/syncany/releases", | |
| "github": "https://api.github.com/repos/syncany/syncany/releases", |
Source: Learnings
✅ Addressed in commit 1ee32de
There was a problem hiding this comment.
Use
checkver.githubfor the release API URL.With
checkver.url, Scoop does not send a configured GitHub token to this API endpoint. A rate-limited check can therefore fail even when the operator has configured a token. Change the key togithub; Scoop accepts this API URL and retains the explicitjsonpathandregex. (github.com)
|
/verify |
|
All changes look good. Wait for review from human collaborators. syncany-cli
|
📋 Problème Traité
The original domains 'syncany.org' and 'get.syncany.org' are no longer active, causing Scoop checkver to fail with 'Le nom distant n'a pas pu être résolu' and fresh package installations to fail with HTTP 404.
💡 Solution Apportée
Migrate homepage, download URL, checkver, and autoupdate to the official GitHub repository 'https://github.com/syncany/syncany' releases. The official binary hash (6ee34b47...) remains identical.
🔗 Issue Associée
N/A
✅ Validation & Actions Réalisées
Note
<manifest-name[@version]|chore>: <general summary of the pull request>🧪 Reproduction de l'Erreur
🔬 Test de la Correction