fix(auth): remove unsafe SAMLResponse WARN logging - BED-9639

[cami-specter]

fixes: BED-9639

Description

Remove sensitive logging. For more info, see https://specterops.atlassian.net/browse/BED-9639

Motivation and Context

Fixes:
https://specterops.atlassian.net/browse/BED-9639

Why is this change required? What problem does it solve?

How Has This Been Tested?

• all tests pass

Screenshots (optional):

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README #672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Security
  • Improved authentication privacy by no longer logging raw SAML responses when parsing fails.
  • Issuer information and private error details continue to be logged for troubleshooting.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Essentials

Run ID: e6424d67-e88b-4f91-8628-1063e41fa9cc

📥 Commits

Reviewing files that changed from the base of the PR and between ea4a25c and 1a52998.

📒 Files selected for processing (1)

• cmd/api/src/api/v2/auth/saml.go

💤 Files with no reviewable changes (1)

• cmd/api/src/api/v2/auth/saml.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The invalid SAML response logging path no longer logs the raw response value. Issuer and private error details remain logged.

Changes

SAML logging

Layer / File(s)	Summary
Exclude raw SAML response cmd/api/src/api/v2/auth/saml.go	The invalid response logging branch no longer includes typedErr.Response. Issuer and private error details remain logged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1a529

Invalid SAML responses no longer expose their raw payload in warning logs, reducing sensitive-data disclosure risk. No concrete merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the removal of unsafe SAMLResponse warning logging and includes the related ticket.
Description check	✅ Passed	The description covers the change, motivation, ticket, testing result, change type, and checklist. The testing details are brief but sufficient for a mostly complete description.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch BED-9639-remove-logs

---

_{Comment @coderabbitai help to get the list of available commands.}