Skip to content

fix(config): bind metrics port to loopback by default #3316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanjio3 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(config): bind metrics port to loopback by default #3316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/api/src/config/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func NewDefaultConfiguration() (Configuration, error) {
SlowQueryThreshold: 100, // Threshold in ms for caching queries
MaxGraphQueryCacheSize: 100, // Number of cache items for graph queries
MaxAPICacheSize: 200, // Number of cache items for API utilities
MetricsPort: ":2112",
MetricsPort: "127.0.0.1:2112",
RootURL: serde.MustParseURL("http://localhost"),
WorkDir: "/opt/bhe/work",
LogLevel: "INFO",
Expand Down
7 changes: 7 additions & 0 deletions cmd/api/src/config/default_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,10 @@ func TestNewDefaultConfig(t *testing.T) {
require.Nilf(t, err, "Failed to create default configuration: %v", err)
require.NotEmpty(t, cfg.Crypto.JWT.SigningKey, "Signing key should not be empty")
}

func TestNewDefaultConfig_BindsLoopback(t *testing.T) {
cfg, err := config.NewDefaultConfiguration()
require.Nilf(t, err, "Failed to create default configuration: %v", err)
require.Equal(t, "127.0.0.1", cfg.BindAddress, "API bind address should default to loopback")
require.Equal(t, "127.0.0.1:2112", cfg.MetricsPort, "Metrics port should default to loopback")
}
Loading