feat(settings)!: load client overwrites from settings/overwrites - #1235
Open
wesleyboar wants to merge 1 commit into
Open
wesleyboar wants to merge 1 commit into
wesleyboar wants to merge 1 commit into
Conversation
Docker clients can mount overwrites/ without replacing settings.py.
BREAKING CHANGE: taccsite_cms/settings/{settings_*,secrets}.py are no longer imported; move them to settings/overwrites/.
Closes #1084
Co-authored-by: Cursor <cursoragent@cursor.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Lets Docker clients mount client settings without replacing the container's
settings.py.Caution
Clients that put overwrites in
taccsite_cms/settings/*.py—— must move them to
taccsite_cms/settings/overwrites/before using this release, because that path will not be imported after this PR is merged.Related
settings.py#1084docker-merge-settings.shSolution withsettings/overwritesCore-CMS-Template#27docker-merge-settings.shSolution withsettings/overwritesCTRN-CMS#4Changes
settings/overwrites/for client settings examplesoverwrites/first (roottaccsite_cms/*.pystill for Camino)Testing
taccsite_cms/settings/overwrites/and runmake start ARGS=--detach.settings_local.pyunderoverwrites/takes effect.taccsite_cms/settings_custom.py(no overwrites file), confirm Camino-style fallback still loads.UI
Skipped.
Made with Cursor