fix: resolve fresh-install and main build dependency failures - #3089
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change updates nested Mantine submenu portal behavior and pins two workspace dependency resolutions. ChangesMenu portal behavior
Workspace resolution
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The compatibility and dependency-resolution fixes introduce no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit sees the menus bloom, Comment |
|
Summary
Fix build and unit-test failures caused by split dependency resolutions, and restore compatibility with fresh Mantine installs.
Rationale
withinPortalfromMenuSubProps. The upstream change is mantinedev/mantine@0ef23a9, a direct commit with no associated PR.prosemirror-transformimports to 1.12.0 andprosemirror-state's dependency to 1.12.1. TheirMappingclasses have distinct private fields, producing incompatible types.@types/noderange also permits both 25.6.0 and 25.9.5, creating separate Vite+/Vitest instances. Unit tests then fail with missing snapshot state.Changes
withinPortal={false}prop fromMantineMenu.Sub.prosemirror-transformto 1.12.1 so direct and transitive imports share one type identity.@types/nodeoverride an exact 25.9.5 pin and regenerate the lockfile to collapse duplicate test-tooling instances.Impact
Submenus continue rendering inside their parent dropdown: older supported Mantine versions default to no portal, and 9.6.1 enforces that internally. The workspace dependency pins align versions already present in the lockfile; published package dependency ranges remain unchanged.
Testing
vp run --no-cache -r build: passes for the final locked tree (including Mantine 9.1.1).vp run --no-cache test: passes, 2,114 tests passed; existing skips retained.vp run lint: passes, zero warnings or errors across 1,177 files.vp install --frozen-lockfileandgit diff --check: pass.describe.skip.Local build/test validation reused the successful Typst compiler artifact from the PR's CI run, whose Rust sources match this checkout.
Summary by CodeRabbit