Skip to content

fix: resolve fresh-install and main build dependency failures - #3089

Merged
nperez0111 merged 2 commits into
mainfrom
fix/fresh-install-tests-34941789169
Sep 15, 2026
Merged

nperez0111 merged 2 commits into
mainfrom
fix/fresh-install-tests-34941789169

Conversation

@nperez0111

@nperez0111 nperez0111 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix build and unit-test failures caused by split dependency resolutions, and restore compatibility with fresh Mantine installs.

Rationale

  • Fresh Install Tests failed because Mantine 9.6.1 removed withinPortal from MenuSubProps. The upstream change is mantinedev/mantine@0ef23a9, a direct commit with no associated PR.
  • The main build and PR build fail because the lockfile resolves direct prosemirror-transform imports to 1.12.0 and prosemirror-state's dependency to 1.12.1. Their Mapping classes have distinct private fields, producing incompatible types.
  • The locked @types/node range also permits both 25.6.0 and 25.9.5, creating separate Vite+/Vitest instances. Unit tests then fail with missing snapshot state.

Changes

  • Remove the redundant withinPortal={false} prop from MantineMenu.Sub.
  • Override prosemirror-transform to 1.12.1 so direct and transitive imports share one type identity.
  • Make the existing @types/node override an exact 25.9.5 pin and regenerate the lockfile to collapse duplicate test-tooling instances.

Impact

Submenus continue rendering inside their parent dropdown: older supported Mantine versions default to no portal, and 9.6.1 enforces that internally. The workspace dependency pins align versions already present in the lockfile; published package dependency ranges remain unchanged.

Testing

  • Reproduced the original Mantine TS2322 failure using the fresh-install workflow's production dependency update and dedupe steps, then verified the Mantine build passes with 9.6.1 after the fix.
  • Reproduced the ProseMirror TS2345 failures with a clean core build and task caching disabled.
  • Reproduced the snapshot-state errors, then verified root and core resolve the same Vite+ instance after pinning Node types.
  • vp run --no-cache -r build: passes for the final locked tree (including Mantine 9.1.1).
  • vp run --no-cache test: passes, 2,114 tests passed; existing skips retained.
  • vp run lint: passes, zero warnings or errors across 1,177 files.
  • vp install --frozen-lockfile and git diff --check: pass.
  • Next.js production integration command completes with both tests skipped by the existing describe.skip.

Local build/test validation reused the successful Typst compiler artifact from the PR's CI run, whose Rust sources match this checkout.

Summary by CodeRabbit

  • Bug Fixes
    • Nested menu submenus now follow standard portal rendering behavior, improving positioning and display across layered interfaces.
  • Compatibility
    • Updated internal workspace version alignment to improve consistency and reliability across editor and testing integrations.

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
blocknote Ready Ready Preview Sep 15, 2026 9:45am UTC
blocknote-website Ready Ready Preview Sep 15, 2026 9:45am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e83ca690-2e55-4907-854e-200fc32e7d31

📥 Commits

Reviewing files that changed from the base of the PR and between c9f1043 and 71a6fc4.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The change updates nested Mantine submenu portal behavior and pins two workspace dependency resolutions.

Changes

Menu portal behavior

Layer / File(s) Summary
Nested submenu rendering
packages/mantine/src/menu/Menu.tsx
Removes withinPortal={false} from MantineMenu.Sub. The root menu retains the setting.

Workspace resolution

Layer / File(s) Summary
Dependency resolution pins
pnpm-workspace.yaml
Pins prosemirror-transform to 1.12.1 and @types/node to 25.9.5.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: yousefed

Merge Risk: ⚪ Minimal · up to 71a6f

The compatibility and dependency-resolution fixes introduce no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: resolving fresh-install and build dependency failures.
Description check ✅ Passed The description covers the main required sections: summary, rationale, changes, impact, and testing. It provides specific failure causes, remediation details, validation results, and impact informatio…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fresh-install-tests-34941789169

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit sees the menus bloom,
Submenus hop through portal rooms.
Exact pins keep packages tight,
ProseMirror resolves just right.
The workspace rests beneath moonlight.

Comment @coderabbitai help to get the list of available commands.

@nperez0111 nperez0111 changed the title fix(mantine): fix fresh-install build with Mantine 9.6.1 fix(mantine): fix compatibility with Mantine 9.6.1 Sep 15, 2026
@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://TypeCellOS.github.io/BlockNote/pr-preview/pr-3089/

Built to branch gh-pages at 2026-09-15 10:02 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@nperez0111 nperez0111 changed the title fix(mantine): fix compatibility with Mantine 9.6.1 fix: resolve fresh-install and main build dependency failures Sep 15, 2026
@nperez0111
nperez0111 merged commit 0042d19 into main Sep 15, 2026
18 of 19 checks passed
@nperez0111
nperez0111 deleted the fix/fresh-install-tests-34941789169 branch September 15, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants