Repository navigation
Use module-level test functions - #3281
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert 57 stateless classes containing 142 static test methods into module-level functions as preparation for Karva. Retain pytest, fixture inputs, test markers, runtime type checks, assertions, and coverage gates.
Group tests into files by API area or behavior. Keep small, cohesive modules together and put genuinely shared helpers in support modules. Remove the organising comments and retain meaningful context in module or test docstrings. Restore shorter function names where the file supplies the context, and retain operation context only where names would collide. Preserve module-local fixture reach when files move.
Share one
model_target_credentials.pymodule between the synchronous and asynchronous Model Target API tests. Move the response builder intomodel_targets/responses.pyand remove both generichelpers.pyfiles.Validation: before and after collection contains the same 467 cases, including parametrized cases. Independent comparisons preserve test bodies and decorators after accounting for the previous moves, fixture changes, and direct
asyncio.runcalls. Moved definitions are unchanged. Applicable Prek pre-commit and pre-push checks and the manual Pylint hook pass.The full suite passes with the existing 100% line and branch coverage gate.