WaylandBackend: Skip cursor update for libdecor and UpdateCursor refactor - #2437
Open
ColinKinloch wants to merge 2 commits into
Open
ColinKinloch wants to merge 2 commits into
ColinKinloch wants to merge 2 commits into
Conversation
This skips the UpdateCursor method in cases where the pointer has not entered a gamescope plane. This fixes an issue where the cursor would be hidden after resizing or moving the window using the libdecor frame.
There are three options for cursors; the host cursor, the guest cursor or no cursor. I flattened the nested blocks and moved the checks for each cursor resource to before where they're attached to the pointer.
ColinKinloch
force-pushed
the
no_hide_libdecor_cursor
branch
from
September 25, 2026 02:06
3fed870 to
e36ed71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This skips the
UpdateCursormethod in cases where the pointer has notentered a gamescope plane.
This fixes an issue where the cursor would be hidden after resizing or
moving the window using the libdecor frame.
I also refactored the method, it should be functionally the same.
There are three options for cursors; the host cursor, the guest cursor or no cursor. I flattened the nested blocks and moved the checks for each cursor resource to before where they're attached to the pointer.
Testing with
master branch
Screencast.From.2026-09-25.00-45-16.mp4
This branch
Screencast.From.2026-09-25.00-46-06.mp4