Repository navigation
WaylandBackend: only await a configure after a real unmap - #2440
Merged
Merged
Conversation
c50ddfa made every NULL attach on the toplevel skip attaches until the next configure. But a NULL attach only unmaps a surface that already has a buffer. If the toplevel was never mapped, the compositor has nothing to reconfigure, so the configure never comes and gamescope never shows a frame. Launching from Steam hits this every time as focus flaps during startup, so the window is hidden before its first frame. Only wait for a configure if the toplevel had a buffer when the NULL buffer was attached. Closes: #2439
3 of 6 tasks
|
I tested it locally and it indeed fixes "no game window" issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c50ddfa made every NULL attach on the toplevel skip attaches until the next configure. But a NULL attach only unmaps a surface that already has a buffer. If the toplevel was never mapped, the compositor has nothing to reconfigure, so the configure never comes and gamescope never shows a frame. Launching from Steam hits this every time as focus flaps during startup, so the window is hidden before its first frame.
Only wait for a configure if the toplevel had a buffer when the NULL buffer was attached.
Closes: #2439