Proper Dedicated server build scripts and itemserver bug

[BringBackQuickPlay]

Two requests:

• Include scripts and instructions for building the dedicated server on Windows/Linux.
• Fix the itemserver bug nonsense on dedicated servers. Something get's fucked up with sdk_inventory data is sent from client to server
  so it arrives broken. Something with symbols. Likely in the engine layer.

Like how are we even supposed to properly distribute a tf2 mod when basic functionality is broken Valve?
Listen Servers are not good enough.

Since the source engine is closed source, the sdk_inventory stuff is something that has to be fixed on your end. All we can do ourself
is workarounds that either use improper channels or flat out bypass what the engine provides.

[DrSTAHP]

So I'm not the only one struggling with this. I've tried both TF2 branch srcds_win64 as well as Source SDK 2013 Multiplayer's one, thought it was something on the server's end when it attempts to connect to TF2 item servers.

You're saying it's an issue with client -> server communication, right? Could you provide a quick rundown on what, to your knowledge, breaks and how the mentioned workarounds work like?

[DrSTAHP]

Okay, I've managed to fix the itemserver issue on dedicated servers and it actually doesn't require any nasty workarounds, unless you're speaking about something completely different of which I'm oblivious to.

Basically, in the CTFGCServerSystem class (tf_gc_server.cpp), which is responsible for retrieving the equipment information from the Steam HTTP API, each time the server attempts to make an HTTP request to the API, it uses an ISteamHTTP* accessor. There are two distinctive accessors for you to use:

1. A client accessor, obtained by calling SteamHTTP().
2. A game server accessor, obtained by calling SteamGameServerHTTP().

The latter is what you're after. The problem being, that CTFGCServerSystem methods responsible for communication with the Steam HTTP API, only the client accessor is being used, there are no checks or subsequent assignments whether it's a dedicated server instance or a client/listen server. Duh, the SteamHTTP() accessor is being called for each single ISteamHTTP method, it's not even assigned to a variable. As a result, on each occasion SteamHTTP() is being called, it always returns a nullptr on dedicated servers.

A quick fix would be as follows:

Declare a private method:

ISteamHTTP* GetSteamHTTPInterface();

And define the method as such:

ISteamHTTP* CTFGCServerSystem::GetSteamHTTPInterface()
{
	if ( !engine )
		return nullptr;

	return ( engine->IsDedicatedServer() ) ? SteamGameServerHTTP() : SteamHTTP();
}

For each method in the CTFGCServerSystem class using ISteamHTTP interface, that currently being:

• CTFGCServerSystem::OnWebapiEquipmentReceived
• CTFGCServerSystem::WebapiEquipmentThinkRequest

In each scope where SteamHTTP() is being called, add this variable:

ISteamHTTP* pSteamHTTPInterface = GetSteamHTTPInterface();

Afterwards, replace any SteamHTTP() references with pSteamHTTPInterface.

Here's some proof it works:

[Jan200101]

#837 also includes a fix for this

[DrSTAHP]

#837 also includes a fix for this

I found it pretty much right after posting the reply. As this issue hasn't been answered in almost a week, I've thought that it's a fresh problem perhaps? The fix uses a preprocessor instead of a run-time check, considering that both are used in the SDK anyways, I'd go with #837 fix instead.