Skip to content

Gate popover handling - #13408

Closed
joedolson wants to merge 2 commits into
WordPress:trunkfrom
joedolson:gate-popover-handler
Closed

Gate popover handling#13408
joedolson wants to merge 2 commits into
WordPress:trunkfrom
joedolson:gate-popover-handler

Conversation

@joedolson

Copy link
Copy Markdown
Contributor

Implement a check for popover, and if not available, hide popover panel.

Prevents errors from the potentially invalid selector :popover-open and prevents uncloseable panels.

Not yet tested in a browser that doesn't support popovers, so this is currently hypothetical.

Trac ticket: https://core.trac.wordpress.org/ticket/65943

Use of AI Tools

None

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Implement a check for popover, and if not available, hide popover panel.

Prevents errors from the potentially invalid selector `:popover-open` and prevents uncloseable panels.
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, adamsilverstein.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@adamsilverstein adamsilverstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@adamsilverstein

Copy link
Copy Markdown
Member

Nice one @joedolson - feel free to proceed if you want to get this in by 7.1.1 (RC on Sept. 10th).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63543
GitHub commit: 3e181d3

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Sep 8, 2026
@adamsilverstein

Copy link
Copy Markdown
Member

I installed an older version of firefox and verified the issue as well as the fix in this PR:

Check:
ff115-popover-detection

Before:
ff115-tooltip-before-fix

After:
ff115-tooltip-after-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants