chore: update workflow icon package and S2 TableView column menu - #10586
Open
yihuiliao wants to merge 3 commits into
Open
chore: update workflow icon package and S2 TableView column menu#10586yihuiliao wants to merge 3 commits into
yihuiliao wants to merge 3 commits into
Conversation
|
Build successful! 🎉 |
snowystinger
reviewed
Sep 8, 2026
| '--iconPrimary': { | ||
| type: 'fill', | ||
| value: 'currentColor' | ||
| value: 'gray-700' |
Member
There was a problem hiding this comment.
won't the color need to respond to hover and active?
Member
Author
There was a problem hiding this comment.
hm that's a good point but currently the text in the header does not change color on hover and active. the tokens don't show the header text color changing based on hover/active state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
check storybook with custom column menus. double check figma's to make sure it matches design
https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=1307
🧢 Your Project: