Say what replaced a retired machine.yml key - #18
Open
johnl-amd wants to merge 1 commit into
Open
Conversation
A machine.yml still holding `runner_type` fails with "unknown key(s): runner_type", which is true but leaves the reader to discover on their own that the key used to be valid and that `labels` took its place. Two files in amd/skills are in exactly that state. The key cannot simply be accepted as an alias. `runner_type: instinct` named a hardware class, and resolving a class onto runner labels needs the second file this format dropped on purpose; `labels: [mi300x]` names the labels directly. So the old key is explained rather than translated. Keyed by a table so the next rename is a line rather than a special case. Signed-off-by: John Lybeck <john.lybeck@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
machine.ymlstill holdingrunner_typefails with:True, but it leaves the reader to work out on their own that the key used to be
valid and that
labelstook its place. Two files inamd/skills(
hyperloom-workload-optimizerandserving-llms-on-instinct) are in exactlythat state today, so this is the first thing anyone pointing skillscope at the
catalog sees.
Now:
Why explain rather than accept
Accepting the old key as an alias would need a class-to-label mapping, which is
the second file this format deliberately does not have.
machine_plan's owndocstring makes the case:
So the old key is explained, not translated. Valid files behave exactly as
before; only the error path changes.
Keyed by a table rather than a special case, so the next rename is one entry.