Fix isDisplayingAtLeast() matcher to factor in the scale of ancestor views. - #2503
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
piper_979797311
branch
2 times, most recently
from
September 14, 2026 02:30
cbcdbe2 to
2307673
Compare
…r views. `isDisplayingAtLeast(N)` determines whether at least N% of a view is visible on the screen by comparing its visible area size against its total view size. Prior to this change, the total view size calculation did not account for ancestor view scales, whereas the visible area size did. Because of this mismatch, `isDisplayingAtLeast(90)` would incorrectly return `false` even when the view was fully visible, specifically when one or more ancestor views were scaled down (shrunk). This change resolves the issue by incorporating ancestor view scaling into the total view size calculation. PiperOrigin-RevId: 979797311
copybara-service
Bot
force-pushed
the
piper_979797311
branch
from
September 15, 2026 02:03
2307673 to
63868e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
isDisplayingAtLeast()matcher to factor in the scale of ancestor views.isDisplayingAtLeast(N)determines whether at least N% of a view is visible on the screen by comparing its visible area size against its total view size.Prior to this change, the total view size calculation did not account for ancestor view scales, whereas the visible area size did. Because of this mismatch,
isDisplayingAtLeast(90)would incorrectly returnfalseeven when the view was fully visible, specifically when one or more ancestor views were scaled down (shrunk).This change resolves the issue by incorporating ancestor view scaling into the total view size calculation.