feat(core): wrapIndent for soft-wrap continuations - #1346
Open
Hyuuh wants to merge 4 commits into
Open
Conversation
Hyuuh
requested review from
Hona,
kommander,
msmps and
simonklee
as code owners
August 7, 2026 06:37
Hyuuh
force-pushed
the
feat/wrap-indent
branch
from
August 15, 2026 21:02
5882e99 to
f1d8d39
Compare
Add optional same-indent for soft-wrapped lines so continuations keep the logical line's leading indent in both layout and paint, with cursor and hit-testing staying consistent. Default remains none.
Yoga measure and truncate used content-only width_cols, so padded continuations could under-report intrinsic width or skip ellipsis.
Hyuuh
force-pushed
the
feat/wrap-indent
branch
from
August 24, 2026 11:27
7aa0dca to
2f856d4
Compare
Public VisualCursor paint APIs include continuation pad; internal translation stays content-relative. Indent tabs use the engine's fixed tab_width, same as utf8.charWidth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrapIndent(none|same, defaultnone) so soft-wrap continuations keep the logical line's leading indent (VS CodewrappingIndent: "same").VirtualLine.pad_colsand narrows continuation wrap width; paint offsets content and hit-testing/cursor stay consistent with painted geometry.TextBufferView/EditorView→TextBufferRenderable/EditBufferRenderable(wrapIndentprop). No breaking change when omitted.Note: orthogonal to #1330 (chunk-boundary reflow after edits).
Test plan
bun run test:native -Dtest-filter="wrap indent"(13/13)wrapIndentget/setwrapMode: "word"|"char"+wrapIndent: "same"— continuations paint under indent; click pad → caret at content start; ↓ from col 0 → content start of continuation