fix(core): clip transparent borders to scissor - #1353
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drawBoxgeometry to the active scissor before any border rendering path runsScrollBoxRenderableregression that places an oversized transparent bordered child above a later siblingCause
drawBoxonly checked whether its bounds overlapped the current scissor. Its transparent-border fast path then wrote directly into the buffer, bypassing the point-level scissor validation used by normal cell writes. A tall bordered child could therefore paint through its scroll viewport and into later UI such as a composer.Verification
origin/mainand passes with this changebun test src/tests/scrollbox.test.ts— 47 passedbun run test:native— 1,877 passed, 5 skippedbun run fmt:checkbun run lintRequested by: @kommander (Sebastian via Slack)