[CALCITE-7768] SqlDialect has no way to unparse a UUID literal - #5250
Open
wasabii wants to merge 1 commit into
Open
[CALCITE-7768] SqlDialect has no way to unparse a UUID literal#5250wasabii wants to merge 1 commit into
wasabii wants to merge 1 commit into
Conversation
xiedeyantu
reviewed
Sep 8, 2026
|
|
||
| public void unparseUuidLiteral(SqlWriter writer, | ||
| SqlUuidLiteral literal, int leftPrec, int rightPrec) { | ||
| writer.literal(literal.toString()); |
Member
There was a problem hiding this comment.
Should this default implementation align with MySQL or PostgreSQL? Should we choose a generic approach, or simply throw an error?
Contributor
Author
There was a problem hiding this comment.
Im not aware of any real database that uses the Calcite syntax. So the default is kinda useless. But that is the Calcite syntax.
Member
There was a problem hiding this comment.
Could you add a test for this default Calcite method?
Contributor
Author
There was a problem hiding this comment.
There already is one I believe. Was there before me.
xuzifu666
reviewed
Sep 9, 2026
wasabii
force-pushed
the
calcite-7768-uuid-literal-dialect
branch
from
September 11, 2026 07:30
afea2ad to
67ded76
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7768
Changes Proposed
A dialect can now decide how a UUID literal is written. The default output is unchanged, so only MSSQL is affected: it writes a plain quoted string, which SQL Server accepts.